Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add redirects for pages that need it #235

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Add redirects for pages that need it #235

merged 5 commits into from
Jun 25, 2020

Conversation

jerelmiller
Copy link
Contributor

Description

Add redirects to pages that need it. This is in accordance to the information in the doc used for the content swarm.

Related Issue(s) / Ticket(s)

If there are any related GitHub Issues or JIRA tickets, add links to them here.

@jerelmiller jerelmiller added documentation Improvements or additions to documentation navigation labels Jun 24, 2020
@jerelmiller jerelmiller requested a review from mmfred June 24, 2020 18:24
Copy link
Contributor

@mmfred mmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerelmiller A problem and a couple missing. Sorry not to add these. I was unclear on the best way with GH.

Copy link
Contributor

@mmfred mmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerelmiller - see my comment for some that need to be fixed/added.

@jerelmiller
Copy link
Contributor Author

@mmfred Thanks for catching those! I think some of these guides hadn't been created when I opened this PR. I've addressed all but 1.

I see we have a /reference/nr1-cli, not a /reference/newrelicone-cli path. Are these the same? If so, which is the correct path? I'll update accordingly.

zstix
zstix previously approved these changes Jun 25, 2020
@mmfred
Copy link
Contributor

mmfred commented Jun 25, 2020

@mmfred Thanks for catching those! I think some of these guides hadn't been created when I opened this PR. I've addressed all but 1.

I see we have a /reference/nr1-cli, not a /reference/newrelicone-cli path. Are these the same? If so, which is the correct path? I'll update accordingly.

let's go with /reference/nr1-cli

That will keep this easier to distinguish from newrelic-cli

Copy link
Contributor

@mmfred mmfred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great - thanks.

@mmfred mmfred merged commit 7c0c959 into master Jun 25, 2020
@nr-opensource-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@jerelmiller jerelmiller deleted the jerel/all-redirects branch July 23, 2020 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation navigation released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants